DEPR: deprecate the data reader package, #10861

[jreback]

closed #10861

[jreback]

@jorisvandenbossche ?

[jorisvandenbossche]

Yep! Merged with dacae10 (I slightly changed the wording and added the imports changes)

[jorisvandenbossche]

And did the same for wb.py: a44e4b3

[jreback]

awesome thxs!

[hayd]

The original idea was to just replace pandas data/web with an import statement, that way no code actually needs to be updated... tests could remain etc.

If there's a warning (not sure there has to be if we change the import) it should include, "install pandas-datareader and replace pandas.io.data with pandas_datareader.data".

Thoughts?

[jreback]

that's how it is; see joris commit above

[hayd]

Great, sorry didn't see that!

But why warn here... if we're later to just replace this in pandas as the import statement, I thought the idea was that users don't need to change any code; they just need to install pandas-datareader.

[jorisvandenbossche]

@hayd You are correct that that was one of the ideas in the discussion, but in my impression we didn't really converged to a final decision there yet (but maybe that is because I am not fully convinced of that position .. :-))

So this can certainly still be discussed/adapted (but indeed, I changed the wording a bit in the commit, so the import change is noted).

[jorisvandenbossche]

See my comment here with my reasons: #8961 (comment) + my last comment.

But if we discuss it further, maybe lets do it in the original issue over there: #8961

[jreback]

I have to agree with joris
this should be very explicit that you are now importing a new package (though it's highly related)

people will see the deprecation if they use the data package - they can then choose to update or not