ABC Tests #10855
Closed
ABC Tests #10855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,8 +271,6 @@ def test_array_equivalent(): | |||
| assert not array_equivalent(np.array([np.nan, 1, np.nan]), | |||
| np.array([np.nan, 2, np.nan])) | |||
| assert not array_equivalent(np.array(['a', 'b', 'c', 'd']), np.array(['e', 'e'])) | |||
| assert array_equivalent(Float64Index([0, np.nan]), Float64Index([0, np.nan])) | |||
| assert not array_equivalent(Float64Index([0, np.nan]), Float64Index([1, np.nan])) | |||
There was a problem hiding this comment.
is their a reason you removed these?
jreback
added
Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10828
I created tests for this issue here: #10828. This is my first time working on Pandas, so please let me know if there is anything wrong with the way I have coded these tests. I haven't updated the documentation, I was unsure of what version I should update and whether I should update at all (it seems that the documentation is for additional features and bug fixes rather than increasing test coverage). I'd love any guidance as to what I can do to fully resolve this issue and how I can best help in the future!