BUG: Fix typo-related bug to resolve #9266 #10576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| columns = ["time", "pri", "pgn", "dst", "src","data"]) | ||
|
|
||
| # Hacky fix for dst column dtype | ||
| expected.dst = expected.dst.astype(object) |
There was a problem hiding this comment.
although this works, the canoncial way to specify is:
expected['dst'] = expected['dst'].astype(object)
|
pls add a note in whatsnew/v0.17.0 |
jreback
added
Bug
IO CSV
|
Thanks for the comments — will try to get to these changes tonight PT or early tomorrow PT. |
|
so this lgtm. pls squash and ping when green. |
|
sorry. pls add a release note in whatsnew/0.17.0. refernce the original issue. |
Fixed typo in parsers.py BUG: Fixed typo-related bug to resolve pandas-dev#9266 Fixed column selection in test cases
captainsafia
force-pushed
the
fix-uint8-typo
branch
from
36d1fd7 to
613aff5
Compare
|
Poops. I messed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9266
Tried replicating the test case provided in the original issue. Let me know if it needs any changes or fixes.