Skip to content

Add Python 3 support and optional parameter "silent" for read_gbq #10572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add Python 3 support and optional parameter "silent" for read_gbq #10572

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2015

Google's libraries support Python 3 since version 1.4.0, so we could add support for Python 3 in read_gbq method.
Also it is not always useful to see "Job not yet complete" printings, so I've added optional parameter that allows disable it.

@ghost ghost changed the title Add Python 3 support for read_gbq Add Python 3 support and optional parameter "silent" for read_gbq Jul 14, 2015
@jorisvandenbossche
Copy link
Member

Ca you:

  • also update the tests?
  • add a release note in whatsnew/v0.17.0.txt ?

@jreback
Copy link
Contributor

jreback commented Jul 15, 2015

these tests are all skipped on py3 (as I don't think the libraries are event installed), e.g. ci/requirements-3.4.txt (as compared to 2.7)

@jreback
Copy link
Contributor

jreback commented Jul 28, 2015

I don't believe ANY of the tests are actually run on travis; they are all skipped because of some import issues.

@ghost
Copy link
Author

ghost commented Jul 28, 2015

Than would it be merged?

@jreback
Copy link
Contributor

jreback commented Jul 28, 2015

if we have sufficient test coverage and validation

@jreback
Copy link
Contributor

jreback commented Sep 14, 2015

cc @parthea

@jreback
Copy link
Contributor

jreback commented Sep 14, 2015

issue is now #11094

pls reopen if you wish to update this issue

@jreback jreback closed this Sep 14, 2015
@parthea
Copy link
Contributor

parthea commented Sep 15, 2015

@a-rodin From version 0.17.0 onwards, you can use the verbose flag to disable printing.

To disable printing:
pd.read_gbq('SELECT * FROM test_dataset.test_table', projectid, verbose=False)

See the documentation here :
http://pandas-docs.github.io/pandas-docs-travis/io.html#io-bigquery

Fixed in #10857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants