Skip to content

BUG : read_csv() twice decodes stream on URL file #10424 #10529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

BotoKopo
Copy link

@BotoKopo BotoKopo commented Jul 8, 2015

As described in #10424 , reading non-utf-8 csv files from URL leads to decoding problems, i.e. a decoding may first be made in io.common.get_filepath_or_buffer() when file is URL.
Modification done makes this function read stream from URL without decoding (this is done later, at the same place as for local files).
It's also used by io.common.read_stata(), io.common.read_json() and io.common.read_msgpack(). Similar problems reading stata and msgpack URL files may also be solved using this modification.

Thanks for reviewing.

@jreback
Copy link
Contributor

jreback commented Jul 8, 2015

needs some tests
u can download s small file and use a file:////url
for json/msgpack create a file encode and access like the above

@jreback jreback added Bug IO Data IO issues that don't fit into a more specific label Unicode Unicode strings labels Jul 8, 2015
@jreback jreback added this to the Next Major Release milestone Jul 8, 2015
@jreback
Copy link
Contributor

jreback commented Oct 11, 2015

@BotoKopo can you add some tests and update

@jreback
Copy link
Contributor

jreback commented Oct 25, 2015

@BotoKopo closing. pls reopen if you would like to update with some tests

@jreback jreback closed this Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug IO Data IO issues that don't fit into a more specific label Unicode Unicode strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants