-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: GH9618 in read_msgpack where DataFrame has duplicate column names #10527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+295
−174
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+4.57 KB
pandas/io/tests/data/legacy_msgpack/0.16.2/0.16.2_x86_64_linux_2.7.10.msgpack
Binary file not shown.
Binary file added
BIN
+4.57 KB
pandas/io/tests/data/legacy_msgpack/0.16.2/0.16.2_x86_64_linux_3.4.3.msgpack
Binary file not shown.
Binary file added
BIN
+14.5 KB
pandas/io/tests/data/legacy_pickle/0.16.2/0.16.2_x86_64_linux_2.7.10.pickle
Binary file not shown.
Binary file added
BIN
+13.8 KB
pandas/io/tests/data/legacy_pickle/0.16.2/0.16.2_x86_64_linux_3.4.3.pickle
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback Is it better to add
locs
(like it is right now) so that newmsgpack
can be decoded in older versions, or replaceitems
withlocs
inencode()
so that the encodedmsgpack
is smaller?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, like you have it now is ok. for back-compat we can only add attributes (and can't change the meaning at all). So this is how I wanted it. The new code will decode using
.locs
as that avoids the duplicates problem, and can read the older msgpacks. This actually also is forward-compat in that a current version can be read by an older version (so this is the best case scenario). We don't have a tests for forward-compat, but you can manually verify (as would need the older code to run in the tests which is 'odd').There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, you were looking at size. Well that is a trivial addition to size (this is one array per block, almost negligble). All that said I think we should remove this in the future (e.g. remove the forward compat, e.g. just use
.items
and just use.locs
). So pls create an issue and I'll it for the future to do this.