Fix and tests for issue #10154 inconsistent behavior with invalid dates #10520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Not all tests pass there are other issues.
| @@ -4461,6 +4461,23 @@ def test_second(self): | |||
| self.assertIsInstance(r2, Float64Index) | |||
| tm.assert_index_equal(r1, r2) | |||
|
|
|||
| class TestDaysInMonth(tm.TestCase): | |||
| def test_day_not_in_month_coerce_true_NaT(self): | |||
| self.assertTrue(isnull(to_datetime('2015-02-29', coerce=True))) | |||
There was a problem hiding this comment.
add the issue number as a comment
There was a problem hiding this comment.
pls add a blank line in between functions
There was a problem hiding this comment.
Added comments and blank lines. Should I open new issues for these test cases that do not pass?
self.assertTrue(isnull(to_datetime('2015-02-29', format="%Y-%m-%d", coerce=True)))
self.assertTrue(isnull(to_datetime('2015-04-31', format="%Y-%m-%d", coerce=True)))
|
merged via 5a76b44 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10154
This addresses the original issue and another discovered with the test cases.
Please review the tests to be sure you agree with the assertions.