TST: Simplify genelate_legacy_pickles.py usage #10509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -143,16 +143,14 @@ def write_legacy_pickles(): | |||
| except: | |||
| import pickle | |||
|
|
|||
| sys_version = version = pandas.__version__ | |||
| version = pandas.__version__ | |||
There was a problem hiding this comment.
The condition looks incorrect in current master and the message is not displayed properly. After this PR, it only need 1 arg (sys.argv must be 2).
# current master
$ generate_legacy_pickles.py 0.16.0
Traceback (most recent call last):
File ".../generate_legacy_pickles.py", line 151, in write_legacy_pickles
output_dir = str(sys.argv[2])
IndexError: list index out of range
|
lgtm |
jreback
added a commit
that referenced
this pull request
Jul 6, 2015
TST: Simplify genelate_legacy_pickles.py usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not input pandas version manually to avoid any mistake.