Skip to content

Fix docstring for na_values in parsers #10479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2015

Conversation

jaidevd
Copy link
Contributor

@jaidevd jaidevd commented Jul 1, 2015

I discovered entirely by accident that the na_values in pd.read_* can be a string. According to the docstring, it can only be a sequence or a dict. This PR fixes that.

@jreback jreback added Docs IO CSV read_csv, to_csv labels Jul 1, 2015
@jreback jreback added this to the 0.17.0 milestone Jul 1, 2015
jreback added a commit that referenced this pull request Jul 1, 2015
Fix docstring for na_values in parsers
@jreback jreback merged commit 6cb762f into pandas-dev:master Jul 1, 2015
@jreback
Copy link
Contributor

jreback commented Jul 1, 2015

thanks!

@jaidevd jaidevd deleted the jd-fix-csv-docstring branch July 1, 2015 11:08
@jorisvandenbossche
Copy link
Member

@jaidevd There are some other places in the docs were this is described (eg in io.rst). Would you like to adapt this as well?

@jaidevd
Copy link
Contributor Author

jaidevd commented Jul 1, 2015

@jorisvandenbossche Sure. Give me a couple of hours.

@jaidevd
Copy link
Contributor Author

jaidevd commented Jul 2, 2015

@jorisvandenbossche #10488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants