DOC: GH10414 Missing example in NA values in GroupBy #10450
Conversation
|
@harshnisar see the contributing docs here pls pull current master and rebase. I know its only a trivial change, but this is in conflict as master changed a tiny bit in this section a couple of days ago. |
harshnisar
force-pushed
the
GH10414-DOC-missing-example
branch
from
485e63e to
6e10194
Compare
|
Done :) |
| See the groupby section :ref:`here <groupby.missing>` for more information. | ||
| ======= | ||
| .. ipython:: python |
There was a problem hiding this comment.
you need to remove the conflict lines
further I would move your change above the see further reference
There was a problem hiding this comment.
@jreback
Embarrassing. Sorry.
harshnisar
force-pushed
the
GH10414-DOC-missing-example
branch
from
6e10194 to
925d6f3
Compare
|
|
||
| See the groupby section :ref:`here <groupby.missing>` for more information. | ||
| ======= |
There was a problem hiding this comment.
I think this snuck in during a rebase/merge?
There was a problem hiding this comment.
@shoyer In my defence, it really did fit well. Changed 👍 Embarrassed.
|
Looks good now! @harshnisar Last question: can you squash the three commits into one? (see end of this section: http://pandas.pydata.org/pandas-docs/stable/contributing.html#committing-your-code) |
harshnisar
force-pushed
the
GH10414-DOC-missing-example
branch
2 times, most recently
from
80c241d to
46def53
Compare
harshnisar
force-pushed
the
GH10414-DOC-missing-example
branch
from
46def53 to
204ce41
Compare
|
@jorisvandenbossche I know by now, this pull request is more of an effort sink for you than a contribution by me. Won't happen from next pulls. |
|
@harshnisar no, no problem! And thanks! |
DOC: GH10414 Missing example in NA values in GroupBy
closes #10414