BUG: GH10365 in interpolate_1d when method is piecewise_polynomial #10435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| s = Series([1, 2, 3, 4, np.nan, 6, np.nan]) | ||
| result = s.interpolate(method='piecewise_polynomial') | ||
| expected = Series([1., 2., 3., 4., 5., 6., 7.]) | ||
| assert_series_equal(expected, result) |
There was a problem hiding this comment.
can you add some tests with nans up front? (maybe for several other interpolate methods as well to make sure nothing breaking)
jreback
added
the
Missing-data
|
Added tests for |
|
can you rebase |
|
Maybe I should just keep the tests for krogh and barbycentric? Piecewise polynomial needs higher order derivatives to be passed in for it to be useful -- otherwise it's just linear interpolation; not sure what a good way would be. |
|
@kawochen what's the status of this? |
|
Still don't have a good way to pass in the higher order derivatives. Will close if for now. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting point for closing #10365.
I only have the trivial case. I think this method (and perhaps other methods as well) needs #10383 for it to be useful.