TST: Use unicode literals in string test #10405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we change ALL usages of |
|
@jreback I think we should not use |
|
ok, that sounds fine. I didn't really search the docs, but if you find any reference saying to use |
|
merge when ready |
|
Thanks. I found no description in the doc, but in wiki. Merging this and fix wiki. |
sinhrks
added a commit
that referenced
this pull request
Jun 23, 2015
TST: Use unicode literals in string test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #10397. Fix some ugly unicode tests. Shall I fix followings also?
compat.u()completely, because the escaped literal is different from normal unicode literals internally.compat.callablebrought back in v3.2 (some code doesn't usecompat.callablealready)