BUG: GH10392 bug where Table.select_column does not preserve column name #10401
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expected = df4['B'] | ||
| try: | ||
| result = store.select_column('df4', 'B') | ||
| except KeyError as err: |
There was a problem hiding this comment.
you don't need this try, except at all, if the result is returned then the test passes
There was a problem hiding this comment.
Ok. I just wanted to change the error type so that it would be clear it is one of the things being tested, not an error in the testing code itself.
|
tests are green |
jreback
added a commit
that referenced
this pull request
Jun 23, 2015
BUG: GH10392 bug where Table.select_column does not preserve column name
|
thanks you siir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #10392