BUG: fix multiple columns as primary key in io.sql.get_schema (GH10385) #10386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
force-pushed
the
get-schema-keys
branch
2 times, most recently
from
de9e1cb to
38177c9
Compare
|
Apparantly there was also an bug in the fallback version, it could only handle single character column names ... @artemyk time we clean this up :-) (I will try to look at your ideas on get_schema and others next week!) |
jorisvandenbossche
force-pushed
the
get-schema-keys
branch
from
38177c9 to
d03c00b
Compare
|
@jreback any remarks? |
| @@ -834,7 +834,11 @@ def _create_table_setup(self): | |||
| for name, typ, is_index in column_names_and_types] | |||
|
|
|||
| if self.keys is not None: | |||
| pkc = PrimaryKeyConstraint(self.keys, name=self.name + '_pk') | |||
| if isinstance(self.keys, string_types): | |||
There was a problem hiding this comment.
maybe you want to ensure list-like first com.is_list_like, then stringify? (then you can join by ',' if necessary)
jorisvandenbossche
force-pushed
the
get-schema-keys
branch
from
d03c00b to
f174c98
Compare
jorisvandenbossche
added a commit
that referenced
this pull request
Jul 3, 2015
BUG: fix multiple columns as primary key in io.sql.get_schema (GH10385)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10385