ENH: #3335 Pivot table support for setting name of margins column. #10296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…column. ref pandas-dev#3335. Adds margin_column parameter to pivot_table so that user can set it to something other than 'All'. Raises ValueError exception if there is a conflict between the value of margin_column and one of the other values appearing in the indices of the pivot table.
lexual
force-pushed
the
issue_3335_pivot_handle_all_for_margins
branch
from
c819d21 to
618110c
Compare
| def pivot_table(data, values=None, index=None, columns=None, aggfunc='mean', | ||
| fill_value=None, margins=False, dropna=True): | ||
| fill_value=None, margins=False, dropna=True, | ||
| margins_column=DEFAULT_MARGIN_COLUMN_NAME): |
There was a problem hiding this comment.
no need to have another variable for this, just set it here in the constructor.
how about call this margins_name
|
this is ok. in general, try to avoid reformatting other text unless its germane as its hard to see what you are changing. If you want to reformat, pls do that in a separate PR. |
|
can you rebase / update |
|
@lexual can you rebase / update |
|
closing, but if you'd like to update, pls reopen |
|
Hi, I've got some availability again to try and help out again. I'll see if I can rebase this and try again. |
|
Doesn't appear I can re-open though. Maybe I have to open a brand new one ?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #3335.
Adds margin_column parameter to pivot_table so that user can set it to
something other than 'All'.
Raises ValueError exception if there is a conflict between the value of
margin_column and one of the other values appearing in the indices of
the pivot table.