BUG: GH10160 in DataFrame construction from dict with datetime64 index #10269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls rebase on master and repush had an issue in the builds |
jreback
added
Bug
Reshaping
| @@ -2954,6 +2954,23 @@ def test_constructor_dict_multiindex(self): | |||
| df = df.reindex(columns=expected.columns, index=expected.index) | |||
| check(df, expected) | |||
|
|
|||
| def test_constructor_dict_datetime64_index(self): | |||
|
|
|||
| data = {1: {np.datetime64('1990-03-15'): 1}, | |||
There was a problem hiding this comment.
for completeness, pls also do a test (you can use a loop), with datetime.datetime and Timestamp (expected should be the same)
|
lets define a function someting like: put in then can use in both places. |
|
Sure I will do that. |
kawochen
force-pushed
the
BUG-FIX-10160
branch
3 times, most recently
from
607a87d to
7ddf7d4
Compare
BUG: GH9456/10160 in Series/DataFrame construction from datetime64 dict Added _dict_compat to deal with datetime64-keyed dict BUG: GH9456 Series construction from dict with datetime64 keys BUG: GH10160 DataFrame construction from nested dict with datetime64 index removed import
|
@kawochen any progress on this? (e.g. incorporating the Series fix as well) |
|
Yes I did that a few days ago. I squashed the commits when I rebased (I'm new to github, maybe I shouldn't have?). |
|
merged via 821542f thanks! FYI, when you push again, I don't know you updated (e.g. there is no notiifcation on that, only on a new PR). So if you want me to have a look, ping! |
This was referenced Jun 10, 2015
This was referenced Sep 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10160
closes #9456
where
DataFrame/Seriesconstruction from nesteddictwithdatetime64index returns aDataFrame\SeriesofNaNs.