Skip to content

Close mysql connection in TestXMySQL to prevent tests freezing #10230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2015

Conversation

graingert
Copy link
Contributor

The unit tests freeze on my machine without this change because you can't drop a table until other connections that are using that table disconnect.

@jorisvandenbossche jorisvandenbossche added the IO SQL to_sql, read_sql, read_sql_query label May 29, 2015
@jorisvandenbossche jorisvandenbossche added this to the 0.17.0 milestone May 29, 2015
@jorisvandenbossche
Copy link
Member

Thanks!
Can confirm this fixes it (have to admit I almost never ran those mysql tests locally ..)

@jorisvandenbossche
Copy link
Member

Will just wait on travis to merge when green.

@graingert
Copy link
Contributor Author

Do you have the same issue locally before this change?

@jorisvandenbossche
Copy link
Member

yes, it specifically hangs on the test_execute_closed_connection test for me. But strange that it runs on travis OK. I almost never ran those old tests (TestXMySQL) locally, but relied on travis for these.

(BTW, we should clean this up once, remove that entire class, but check if there is still something tested there that is not tested in the other tests)

jorisvandenbossche added a commit that referenced this pull request May 29, 2015
Close mysql connection in TestXMySQL to prevent tests freezing
@jorisvandenbossche jorisvandenbossche merged commit b144cc1 into pandas-dev:master May 29, 2015
@graingert graingert deleted the fix-testxmysql branch May 29, 2015 13:20
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.17.0, 0.16.2 Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants