BUG: Holiday(..) with both offset and observance raises #10226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -737,6 +737,17 @@ def test_get_period_field_raises_on_out_of_range(self): | |||
| def test_get_period_field_array_raises_on_out_of_range(self): | |||
| self.assertRaises(ValueError, period.get_period_field_arr, -1, np.empty(1), 0) | |||
|
|
|||
|
|
|||
| class TestHolidayConflictingArguments(tm.TestCase): | |||
|
|
|||
There was a problem hiding this comment.
can you add the issue number as a comment here
|
pls add a release note (put it in the API section for 0.17.0). minor changes otherwise. pls ping when green on travis. |
bwillers
force-pushed
the
holiday_error_msg
branch
from
3880fe2 to
85628a2
Compare
|
As requested. By the way, five points to whoever wrote the 'contributing to pandas' doc section. |
|
thanks to cc @rockg who put most of that together! |
|
cc @rockg look good to you? |
|
Looks good to me. Let's keep the original issue open until that requested behavior is supported. @bwillers Glad it was useful...hopefully removes the major hurdles to helping out. |
|
merged via d513986 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10217
Doesn't fix the underlying issue yet, but at least raises on the unsupported behavior.