add try / except to address issue #10154 to_datetime, Inconsistent be… #10216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…havior with invalid dates.
|
needs tests |
| @@ -737,6 +737,13 @@ def test_get_period_field_raises_on_out_of_range(self): | |||
| def test_get_period_field_array_raises_on_out_of_range(self): | |||
| self.assertRaises(ValueError, period.get_period_field_arr, -1, np.empty(1), 0) | |||
|
|
|||
| class TestDaysInMonth(tm.TestCase): | |||
| def test_day_not_in_month_coerce_true(self): | |||
There was a problem hiding this comment.
pls add the issue number as a comment
There was a problem hiding this comment.
I thought I did, not sure what went wrong.
| self.assertTrue(isnull(to_datetime('2015-02-32', format="%Y-%m-%d", coerce=True))) | ||
| self.assertTrue(isnull(to_datetime('2015-04-31', format="%Y-%m-%d", coerce=True))) | ||
| def test_day_not_in_month_coerce_false(self): | ||
| self.assertRaises(ValueError, to_datetime, '2015-02-29', format="%Y-%m-%d", coerce=False) |
There was a problem hiding this comment.
yeh, test both errors='ignore' and errors='raise' here
There was a problem hiding this comment.
This looks correct
In [10]: pd.to_datetime('2015-02-29', errors='ignore', coerce=False)
Out[10]: '2015-02-29'
I would expect the same from this but get a ValueError.
In [12]: pd.to_datetime('2015-02-29', errors='ignore', format="%Y-%m-%d", coerce=False)
....
ValueError: day is out of range for month
adding format="%Y-%m-%d" should not change the output.
Is this correct and also needs to be fixed?
|
can you rebase |
|
On Fri, Jun 26, 2015 at 5:39 PM, jreback [email protected] wrote:
I will work on that this weekend. |
update pymysql to 0.6.3 to avoid cursor bugs Add documentation and tests for SQLAlchemy connectables explicit reference to connection/engine in docs Temporary table test pass compile the connectable
Updated the docstring to make clear that a HDFStore is required for a buffer, if a path is not directly passed
support both sqlalchemy engines and connections
Updated to_hdf doc string
TST: DataFrame.quantile should have Float64Index
…havior with invalid dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10154 to_datetime, Inconsistent behavior with invalid dates.
results are now