BUG: Index.name is lost during timedelta ops #10158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
while refactoring my code from #9965 to use this I found that it might be nice to have the same method for multiindex with the 'names' attribute instead, what do you think? |
|
It is nice the same logic can be used. please change it accordingly on your pr, and I'll rebase. |
jreback
added a commit
that referenced
this pull request
May 18, 2015
BUG: Index.name is lost during timedelta ops
|
thanks @sinhrks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9926.
CC @hsperr I've changed
common._maybe_match_namesto work with not-named objects, and hopefully can use in #9965 also.