-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Index.union cannot handle array-likes #10157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
self.assertTrue(tm.equalContents(intersect, second)) | ||
|
||
# GH 10149 | ||
cases = [klass(second.values) for klass in [np.array, Series, list]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move these to Base (so that they get tested for all types)?
rebase / address comments when you have a chance |
Rebased. I've added tests to What I'd like to confirm here is
|
Let me update
|
Rebased, and updated top descriptions about |
BUG: Index.union cannot handle array-likes
thanks @sinhrks |
Closes #10149.
intersection
,union
,difference
andsym_diff
.TimedeltaIndex
previously did additional input check which is inconsistent with others. Made it work as the same manner as others.MultiIndex
set-ops should only accept list-likes of tuples. Implement the logic and add explicit test.str
which has__iter__
in py3.NOTE: This DOESN'T care the
name
attribute checks, which is being worked in #9965.