Skip to content

PERF: BlockPlacement.copy() speed-up #10073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

PERF: BlockPlacement.copy() speed-up #10073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions pandas/lib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1641,12 +1641,21 @@ cdef class BlockPlacement:

cdef bint _has_slice, _has_array, _is_known_slice_like

def __init__(self, val):
def __init__(self, val, fastpath=False):
cdef slice slc

self._has_slice = False
self._has_array = False

if fastpath:
if isinstance(val, slice):
self._as_slice = val
self._has_slice = True
else:
self._as_array = val
self._has_array = True
return

if isinstance(val, slice):
slc = slice_canonize(val)

Expand Down Expand Up @@ -1783,12 +1792,11 @@ cdef class BlockPlacement:

return self

cdef BlockPlacement copy(self):
cdef slice s = self._ensure_has_slice()
if s is not None:
return BlockPlacement(s)
cpdef BlockPlacement copy(self):
if self._as_slice is not None:
return BlockPlacement(self._as_slice, fastpath=True)
else:
return BlockPlacement(self._as_array)
return BlockPlacement(self._as_array, fastpath=True)

def add(self, other):
return self.copy().iadd(other)
Expand Down