Skip to content

BUG: Series.align resets name when fill_value is specified #10067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2015
Merged

BUG: Series.align resets name when fill_value is specified #10067

merged 1 commit into from
May 30, 2015
+20 −13

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented May 6, 2015 

import pandas.util.testing as tm

ts = tm.makeTimeSeries()
ts.name = 'ts'
a, b = ts[2:], ts[:5]

# OK (names are preserved)
aa, ba = a.align(b)
aa.name
# ts
ba.name
# ts

# NG, specifying fill_value resets names
aa, ba = a.align(b, fill_value=-1)
aa.name
# None
ba.name
# None

@sinhrks sinhrks added Bug Datetime Datetime data dtype Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels May 6, 2015
@sinhrks sinhrks force-pushed the align_name branch 2 times, most recently from 6d49687 to fc14dfb Compare May 12, 2015 12:57
@sinhrks sinhrks added this to the 0.17.0 milestone May 12, 2015
@sinhrks sinhrks force-pushed the align_name branch 3 times, most recently from 77dc2f8 to 725178a Compare May 20, 2015 12:20
@sinhrks
Copy link
Member Author

sinhrks commented May 30, 2015

@jreback Could you review this?

@jreback
Copy link
Contributor

jreback commented May 30, 2015

lgtm

sinhrks added a commit that referenced this pull request May 30, 2015
@sinhrks
Merge pull request #10067 from sinhrks/align_name
2709f77 
BUG: Series.align resets name when fill_value is specified
@sinhrks sinhrks merged commit 2709f77 into pandas-dev:master May 30, 2015
@sinhrks
Copy link
Member Author

sinhrks commented May 30, 2015

Thanks!

@sinhrks sinhrks deleted the align_name branch May 30, 2015 13:49
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.17.0, 0.16.2 Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Datetime Datetime data dtype Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
0.16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sinhrks @jreback @jorisvandenbossche