ENH: support StringMethods index and rindex #10045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are there any other routines that have an |
|
@jreback good catch, return type of I also added to the release note |
mortada
force-pushed
the
str_index
branch
2 times, most recently
from
80080fb to
0cd5d83
Compare
24 tasks
|
@jreback do you think this can make 0.16.1? seems like it'd be nice to get all the string methods in |
| @@ -39,6 +39,7 @@ Enhancements | |||
| Timestamp('2014-08-01 07:00') + BusinessHour() | |||
| Timestamp('2014-08-01 16:30') + BusinessHour() | |||
|
|
|||
| - Added ``StringMethods.index()`` and ``rindex`` which behave the same as standard ``str`` (:issue:`10045`) | |||
There was a problem hiding this comment.
can u move this in the whatsnew with all the other steing changes
|
was also passing before, right? |
|
yes this was passing too, just changing docs |
jreback
added a commit
that referenced
this pull request
May 8, 2015
ENH: support StringMethods index and rindex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a part of #9111
@sinhrks @jreback