Skip to content

BUG: losing Index/Series names master issue #9862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8 of 12 tasks
jreback opened this issue Apr 12, 2015 · 9 comments · Fixed by #19849
Closed
8 of 12 tasks

BUG: losing Index/Series names master issue #9862

jreback opened this issue Apr 12, 2015 · 9 comments · Fixed by #19849
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves

Comments

@jreback
Copy link
Contributor

jreback commented Apr 12, 2015

cases where index names are lost in various operations, most of these involve an issue in concat

Index.name

Series.name
@jreback jreback added Bug Indexing Related to indexing on series/frames, not to indexes themselves Master Tracker High level tracker for similar issues labels Apr 12, 2015
@jreback jreback added this to the Next Major Release milestone Apr 12, 2015
@jreback jreback mentioned this issue Apr 12, 2015
Closed
@ksanghai
Copy link
Contributor

I am working on this issue now.. lets see how far I can get..

@jreback
Copy link
Contributor Author

jreback commented Apr 13, 2015 

In [1]: Index(['a'],name='foo').append(Index(['b']))
Out[1]: Index([u'a', u'b'], dtype='object')

In [2]: Index(['a'],name='foo').append(Index(['b'])).name

ksanghai added a commit to ksanghai/pandas that referenced this issue Apr 13, 2015
@ksanghai
added the fix for index name lost pandas-dev#9862 and also added the …
ccb8400 
…corresponding test in

test_index
@ksanghai ksanghai mentioned this issue Apr 13, 2015
Closed
jreback pushed a commit that referenced this issue Apr 14, 2015
@ksanghai @jreback
added the fix for index name lost #9862 and also added the correspond…
f8ca3b7 
…ing test in

test_index
@sinhrks
Copy link
Member

sinhrks commented Apr 14, 2015

How about making testing.assert_index_equal to check name attribute (maybe optionally) to detect this kind of problems?

@jorisvandenbossche
Copy link
Member

+1 testing.assert_frame_equal does this already, so it seems logical that assert_index_equal can do this as well (and then we can also clean up assert_frame_equal a bit)

@jreback
Copy link
Contributor Author

jreback commented Apr 14, 2015

IIRC the checking names option was turned off as a default quite a while ago, because too many things were breaking; I suspect it would be much closer nowadays. so +1 here as well.

This was referenced Apr 18, 2015
Closed
Closed
@sinhrks
Copy link
Member

sinhrks commented Apr 18, 2015

Added #9925 and #9926 to the list, which found by changing assert_index_equal to check index names.

@sergeny
Copy link

sergeny commented Apr 20, 2015

Independently stumbled upon the same thing: #9943

@jreback jreback mentioned this issue Apr 20, 2015
Closed
hsperr added a commit to hsperr/pandas that referenced this issue Apr 22, 2015
@hsperr
interesction and union changed index names. fixes pandas-dev#9943 par…
f2565bd 
…tly pandas-dev#9862
@hsperr hsperr mentioned this issue Apr 22, 2015
Closed
hsperr added a commit to hsperr/pandas that referenced this issue Apr 22, 2015
@hsperr
FIX: interesction and union don't index names anymore. fixes pandas-d…
4e4d6f5 
…ev#9943 partly pandas-dev#9862
hsperr added a commit to hsperr/pandas that referenced this issue Apr 22, 2015
@hsperr
FIX: interesction and union don't change index names anymore. fixes p…
c1db455 
…andas-dev#9943 partly pandas-dev#9862
hsperr added a commit to hsperr/pandas that referenced this issue Apr 23, 2015
@hsperr
FIX: interesction and union correct name chaning behavior. fixes pand…
91ced29 
…as-dev#9943 partly pandas-dev#9862
hsperr added a commit to hsperr/pandas that referenced this issue Apr 23, 2015
@hsperr
FIX: interesction and union correct name chaning behavior. fixes pand…
a04c9cf 
…as-dev#9943 partly pandas-dev#9862
hsperr added a commit to hsperr/pandas that referenced this issue Apr 23, 2015
@hsperr
FIX: interesction and union correct name chaning behavior. fixes pand…
991a6b6 
…as-dev#9943 partly pandas-dev#9862
hsperr added a commit to hsperr/pandas that referenced this issue Apr 23, 2015
@hsperr
FIX: interesction and union correct name chaning behavior. fixes pand…
725ffe5 
…as-dev#9943 partly pandas-dev#9862
hsperr added a commit to hsperr/pandas that referenced this issue Apr 23, 2015
@hsperr
FIX: interesction and union correct name chaning behavior. fixes pand…
a641434 
…as-dev#9943 partly pandas-dev#9862
@sinhrks sinhrks mentioned this issue Apr 23, 2015
Merged
hsperr added a commit to hsperr/pandas that referenced this issue May 17, 2015
@hsperr
FIX: interesction and union correct name chaning behavior. fixes pand…
d494287 
…as-dev#9943 partly pandas-dev#9862
@sinhrks sinhrks mentioned this issue Jul 23, 2015
Merged
@sinhrks sinhrks changed the title BUG: losing index names master issue BUG: losing Index/Series names master issue Jul 23, 2015
max-sixty pushed a commit to max-sixty/pandas that referenced this issue Jul 27, 2015
@hsperr @max-sixty
FIX: interesction and union correct name chaning behavior. fixes pand…
efd8984 
…as-dev#9943 partly pandas-dev#9862
@chris-b1 chris-b1 mentioned this issue Aug 30, 2015
Merged
@stahlous stahlous mentioned this issue Oct 27, 2015
Closed
@chris-b1 chris-b1 mentioned this issue May 16, 2016
Closed
4 tasks
@jorisvandenbossche jorisvandenbossche mentioned this issue Jan 4, 2017
Closed
@jreback jreback modified the milestones: Next Major Release, High Level Issue Tracking Sep 24, 2017
@Licht-T
Copy link
Contributor

Licht-T commented Oct 24, 2017

@jreback #8093 seems already fixed.
#8093 (comment)

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Feb 22, 2018 •
edited
Loading

@jreback #11193 is closed by #11193
#3570 was closed since it is for Panel (remark from you is "won't fix")

@Dr-Irv Dr-Irv mentioned this issue Feb 22, 2018
Merged
3 tasks
@TomAugspurger TomAugspurger removed the Master Tracker High level tracker for similar issues label Jul 6, 2018
@TomAugspurger TomAugspurger removed this from the High Level Issue Tracking milestone Jul 6, 2018
gfyoung pushed a commit that referenced this issue Nov 6, 2018
@Dr-Irv @gfyoung
BUG: names on union and intersection for Index were inconsistent (#19849
810826d 
)

Closes gh-9862.

xref gh-9943.
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this issue Nov 14, 2018
@Dr-Irv @JustinZhengBC
BUG: names on union and intersection for Index were inconsistent (pan…
2acb22c 
…das-dev#19849)

Closes pandas-devgh-9862.

xref pandas-devgh-9943.
tm9k1 pushed a commit to tm9k1/pandas that referenced this issue Nov 19, 2018
@Dr-Irv @tm9k1
BUG: names on union and intersection for Index were inconsistent (pan…
a3cb293 
…das-dev#19849)

Closes pandas-devgh-9862.

xref pandas-devgh-9943.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this issue Feb 28, 2019
@Dr-Irv @Pingviinituutti
BUG: names on union and intersection for Index were inconsistent (pan…
108f2ae 
…das-dev#19849)

Closes pandas-devgh-9862.

xref pandas-devgh-9943.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this issue Feb 28, 2019
@Dr-Irv @Pingviinituutti
BUG: names on union and intersection for Index were inconsistent (pan…
47239bd 
…das-dev#19849)

Closes pandas-devgh-9862.

xref pandas-devgh-9943.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: names on union and intersection for Index were inconsistent (GH9943 GH9862) Dr-Irv/pandas
8 participants
@jreback @jorisvandenbossche @TomAugspurger @Licht-T @sinhrks @sergeny @ksanghai @Dr-Irv