Skip to content

Holiday.dates always fails with tz-aware input #9825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ssanderson opened this issue Apr 7, 2015 · 1 comment · Fixed by #9824
Closed

Holiday.dates always fails with tz-aware input #9825

ssanderson opened this issue Apr 7, 2015 · 1 comment · Fixed by #9824
Labels
Enhancement Timezones Timezone data dtype
Milestone
0.16.1

Comments

@ssanderson
Copy link
Contributor

The conversion from start_date to base_date on https://github.com/pydata/pandas/blob/master/pandas/tseries/holiday.py#L206 drops tz information, which causes the DatetimeIndex constructor to barf if end_date is tz-aware. Fixed by #9824.
@jreback jreback added the Timezones Timezone data dtype label Apr 7, 2015
@jreback jreback changed the title Holiday.dates always fails with tz-aware input Holiday.dates always fails with tz-aware input Apr 7, 2015
@ssanderson ssanderson mentioned this issue Apr 8, 2015
Merged
@jreback jreback added this to the 0.16.1 milestone Apr 8, 2015
@jreback
Copy link
Contributor

jreback commented Apr 8, 2015

closed by #9824

@jreback jreback closed this as completed Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Timezones Timezone data dtype
Projects
None yet
Milestone
0.16.1
Development

Successfully merging a pull request may close this issue.

Allow tz-aware inputs in Holiday.dates ssanderson/pandas
2 participants
@jreback @ssanderson