Skip to content

test.sh shows couple of failures on OSX 10.10.1 #9281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tvyomkesh opened this issue Jan 17, 2015 · 3 comments · Fixed by #9296
Closed

test.sh shows couple of failures on OSX 10.10.1 #9281

tvyomkesh opened this issue Jan 17, 2015 · 3 comments · Fixed by #9296

Comments

@tvyomkesh
Copy link
Contributor

Not sure if this is reproducible by others in their enviroment/platform but here is what I am seeing on my machine.

FAIL: test_now (pandas.tseries.tests.test_tslib.TestTimestamp)

Traceback (most recent call last):
File "/Users/tvyomkesh/pandas/pandas/tseries/tests/test_tslib.py", line 343, in test_now
self.assertTrue((ts_from_string_tz.tz_localize(None) - ts_from_string) < delta)
AssertionError: False is not true

FAIL: test_today (pandas.tseries.tests.test_tslib.TestTimestamp)

Traceback (most recent call last):
File "/Users/tvyomkesh/pandas/pandas/tseries/tests/test_tslib.py", line 359, in test_today
self.assertTrue((ts_from_string_tz.tz_localize(None) - ts_from_string) < delta)
AssertionError: False is not true

Ran 7309 tests in 500.577s
FAILED (SKIP=468, failures=2)
@tvyomkesh tvyomkesh changed the title test.sh shows couple of failures on OSX 10.10.1 with pandas v0.15.2 test.sh shows couple of failures on OSX 10.10.1 Jan 17, 2015
@jreback
Copy link
Contributor

jreback commented Jan 17, 2015

pls show pd.show_versions().

@tvyomkesh
Copy link
Contributor Author 

In [2]: pd.show_versions()
INSTALLED VERSIONS
------------------
commit: d8a03dae7728e5d9a2f12f0b7b0c784a15c7f322
python: 2.7.9.final.0
python-bits: 64
OS: Darwin
OS-release: 14.0.0
machine: x86_64
processor: i386
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
pandas: 0.15.2-95-g5886a1d
nose: 1.3.4
Cython: 0.21.2
numpy: 1.9.1
scipy: 0.14.1
statsmodels: None
IPython: 2.3.1
sphinx: 1.2.3
patsy: None
dateutil: 2.4.0
pytz: 2014.10
bottleneck: None
tables: None
numexpr: None
matplotlib: None
openpyxl: None
xlrd: None
xlwt: None
xlsxwriter: None
lxml: None
bs4: None
html5lib: None
httplib2: None
apiclient: None
rpy2: 2.4.2
sqlalchemy: 0.9.8
pymysql: None
psycopg2: None

@sinhrks
Copy link
Member

sinhrks commented Jan 18, 2015

I'm using OSX 10.10.1 also, and unable to reproduce the issue.

My assumption is a test problem, ts_from_string_tz.tz_localize(None) which convert tz-aware timestamp to normal timestamp. Maybe your timezone is later than 'US/Eastern'?

My timezone (UTC+9) and each calculation results are as below:

self.assertTrue((ts_from_string_tz.tz_localize(None) - ts_from_string) < delta)
  • ts_from_string_tz.tz_localize(None): 2015-01-18 11:52:33.726936
  • ts_from_string: 2015-01-17 21:52:33.727108
  • ts_from_string_tz.tz_localize(None) - ts_from_string): -1 days +10:00:00.000172

Garrett-R added a commit to Garrett-R/pandas that referenced this issue Jan 19, 2015
@Garrett-R
BUG: Fixes pandas-dev#9281: fixes to tseries.tests.test_tslib.TestTim…
7520246 
…estamp

The last tests of both `test_now` and `test_today` were passing for anyone with a timezone
of UTC-5 or greater (but failed, for example, for people in US/Pacific).  The test was not
testing what the original author meant it to (which is that the times are very close
together) so I added abs(.) around the Timedeltas and also fixed the errant test.
@Garrett-R Garrett-R mentioned this issue Jan 19, 2015
Merged
jreback added a commit that referenced this issue Jan 19, 2015
@jreback
Merge pull request #9296 from Garrett-R/fix_GH9281
02cbd9e 
BUG: Fixes #9281: fixes to tseries.tests.test_tslib.TestTimestamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: Fixes #9281: fixes to tseries.tests.test_tslib.TestTimestamp Garrett-R/pandas
3 participants
@tvyomkesh @jreback @sinhrks