Skip to content

DateRange - minute vs. minutes #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattias-lundell opened this issue Feb 28, 2012 · 3 comments
Closed

DateRange - minute vs. minutes #838

mattias-lundell opened this issue Feb 28, 2012 · 3 comments
Assignees
@wesm
Labels
Bug Datetime Datetime data dtype
Milestone
0.7.1

Comments

@mattias-lundell
Copy link

I tried to create a DateRange in five minute steps.

In [40]: DateRange(datetime(2011,11,11), datetime(2011,11,12), offset=DateOffset(minute=5))

The %CPU is 100 and it consumes a lot of memory but nothing happens, no result and no error. I continued to experiment and realized that i wrote 'minute' instead of 'minutes'

In [41]: DateRange(datetime(2011,11,11), datetime(2011,11,12), offset=DateOffset(minutes=5))

My suggestion is to maybe add some kind of argument check.
@adamklein
Copy link
Contributor

Thanks for pointing this out. The problem is DateOffset takes as parameters anything that relativedelta from dateutil does. i think we should disallow this for 0.8

@ghost ghost assigned wesm Feb 28, 2012
@wesm
Copy link
Member

wesm commented Feb 28, 2012

Should be easy to catch the infinite loop. I'll take a look

@wesm
Copy link
Member

wesm commented Feb 28, 2012

I already fixed this on 1/26 in daf0c67 . Will be in 0.7.1 release

@wesm wesm closed this as completed Feb 28, 2012
wesm added a commit that referenced this issue Feb 28, 2012
@wesm
TST: unit test for #838
cfa4b6a
adamklein added a commit that referenced this issue Feb 28, 2012
@adamklein
TST: fix lingering line of code from #838
0cb2a82
yarikoptic added a commit to neurodebian/pandas that referenced this issue Mar 2, 2012
@yarikoptic
Merge commit 'v0.7.1-1-ga2e86c2' into debian
4e19ac4 
* commit 'v0.7.1-1-ga2e86c2': (90 commits)
  BUG: Fix Series, DataFrame plot() for non numerical/datetime (Multi)Index (closes pandas-dev#741).
  RLS: Version 0.7.1
  DOC: release notes, what's new, change dev version to 0.7.1
  BUG: close pandas-dev#839, another case where nan may be assigned to int series
  ENH: raise NotImplementedError if user tries to iterate over .ix, GH pandas-dev#840
  BUG: fixed null-check per pandas-dev#839
  BUG: close pandas-dev#839, exception on assigning NA to bool or int64 series
  TST: more test coverage for release target
  TST: added core coverage
  TST: fix lingering line of code from pandas-dev#838
  DOC: added yet a bit more to release notes
  TST: unit test for pandas-dev#838
  DOC: added more release notes
  BUG: raise more helpful error msg for pandas-dev#835
  TST: added skip excel test for no xlrd installed
  BUG: close pandas-dev#835, add option to suppress index inference
  BUG: close pandas-dev#837, excelfile throws an exception for two-line file
  ENH: fill_value arg in DataFrame.reindex/reindex_axis, add fillna to sparse objects, GH pandas-dev#784
  ENH: add fill_value argument to Series.reindex, DataFrame next, pandas-dev#784
  ENH: concat Series with axis=1 for completeness, GH pandas-dev#787
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesm wesm

Labels
Bug Datetime Datetime data dtype
Projects
None yet
Milestone
0.7.1
Development

No branches or pull requests
3 participants
@wesm @adamklein @mattias-lundell