Skip to content

TST: add tests for Series/Panel with non-unique index in to_hdf with fixed format #7813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Jul 21, 2014 · 10 comments
Closed
Labels
good first issue IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite

Comments

@jreback
Copy link
Contributor

jreback commented Jul 21, 2014

xref #7788

@jreback jreback added this to the 0.15.0 milestone Jul 21, 2014
@jreback
Copy link
Contributor Author

jreback commented Jul 21, 2014

cc @filmor

@filmor
Copy link
Contributor

filmor commented Jul 22, 2014

I'll look into this.

filmor added a commit to filmor/pandas that referenced this issue Aug 19, 2014
The exception is also raised for `Panel` but not for `Series` objects.

Fixes pandas-dev#7813.
@filmor
Copy link
Contributor

filmor commented Aug 20, 2014

Would you mind having a look at the build failures? https://travis-ci.org/filmor/pandas/builds/32934493

The only changes I did against master are these: filmor@1dcd687

I don't know why test_wide_table_dups is failing now and it also seems like the table format can't handle non-unique indexes for panels as well. Is this by design?

@jreback
Copy link
Contributor Author

jreback commented Aug 20, 2014

iirc this is not possible to store these non unique indexers - well u can store them but the non uniques are filtered out in the way back (they are stored in a flattened way(

trace the reading and u will see -

@filmor
Copy link
Contributor

filmor commented Aug 20, 2014

Okay, but in this case it should (like I outlined in #7788) raise an exception for all of these cases. What is the intended behaviour?

Also, this doesn't explain why test_wide_table_dups fails.

@jreback
Copy link
Contributor Author

jreback commented Aug 20, 2014

you need to trace it. I don't really remember exactly what it does in the case of non-unique axes for table format.

@jreback
Copy link
Contributor Author

jreback commented Sep 9, 2014

@filmor ?

@filmor
Copy link
Contributor

filmor commented Oct 22, 2014

Hi jreback, I don't really know how to continue.

@jreback
Copy link
Contributor Author

jreback commented Oct 22, 2014

why don't you submit a pull-request with what you have and can take a look

@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
@jreback
Copy link
Contributor Author

jreback commented Jul 6, 2018

closing as won't fix.

@jreback jreback closed this as completed Jul 6, 2018
@jreback jreback modified the milestones: Contributions Welcome, No action Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

3 participants