-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Performance decrease of groupby.first for datetime64 in 0.14 #7555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
what version were you using? |
This is from 0.14.0, but I have experienced the same on master yesterday. |
I see that did u have a version where it was fast? |
Latest 0.13 was definitely fine. I will check it again just to make sure. UPDATE: Just tested 0.13.1 and it takes even longer. Maybe the bug is on the numpy side? I will try to go deeper into that and post the findings here. |
Downgrading numpy or pandas didn't help. Do you get the same results as me? Could you put me on the right direction where to look? Thanks. |
This was falling back to python space for the aggregation, so was much slower. fix shortly. |
see #7560 |
give a try on master |
datetime works fine now, but I experience the same problem with
|
@Marigold ok fixed up...thanks for the report. was not checking these cases, and had a regression. |
Works perfectly. Thanks for a quick feedback. |
I have seen a dramatic (around 100x) slowdown of
groupby.first
method fordatetime64
type after updating to 0.14.Here is an example:
Result:
Same for
int
typeResult:
The text was updated successfully, but these errors were encountered: