Skip to content

VIS: Warn when a user passes an ignored argument #7045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TomAugspurger opened this issue May 5, 2014 · 3 comments
Open

VIS: Warn when a user passes an ignored argument #7045

TomAugspurger opened this issue May 5, 2014 · 3 comments
Labels
Enhancement Visualization plotting Warnings Warnings that appear or should be added to pandas

Comments

@TomAugspurger
Copy link
Contributor

So the plot method is quite... flexible (bloated). This does give great flexibility for quickly plotting stuff, but not all args make sense for every kind of plot. Some plots (for example PiePlot) will ignore arguments like logx since it doesn't make any sense. This case is obviously nonsense, so it probably won't happen, but it would be nice to decorate the _args_adjust methods to warn when arguments are being ignored / adjusted if the user has explicitly changed them from the defaults. I should be able to do this one.
@TomAugspurger TomAugspurger added this to the 0.14.1 milestone May 5, 2014
@TomAugspurger TomAugspurger mentioned this issue May 5, 2014
Merged
@jreback
Copy link
Contributor

jreback commented Jun 5, 2014

@TomAugspurger ?

@jreback jreback modified the milestones: 0.15.0, 0.14.1 Jun 26, 2014
@sinhrks
Copy link
Member

sinhrks commented Jul 30, 2014

As a reminder:

@sinhrks sinhrks mentioned this issue Aug 19, 2014
Merged
@TomAugspurger TomAugspurger mentioned this issue Jan 16, 2015
Open
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
@datapythonista datapythonista modified the milestones: Contributions Welcome, Someday Jul 8, 2018
@mroeschke mroeschke added Enhancement Warnings Warnings that appear or should be added to pandas labels Apr 11, 2021
@mroeschke mroeschke removed this from the Someday milestone Oct 13, 2022
@adityaraute
Copy link

Shouldn't this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Visualization plotting Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jreback @TomAugspurger @sinhrks @datapythonista @mroeschke @adityaraute