-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Series/DataFrame.rank() doesn't handle np.inf properly #6945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
@nspies this has your name on it too! |
I'm using pandas '0.20.1'. Ranking series with np.inf still yields np.nan. Will this be fixed ?
|
@peterpanmj pull request for this are welcome, its pretty straightforward to fix. |
peterpanmj
added a commit
to peterpanmj/pandas
that referenced
this issue
Dec 3, 2017
jreback
pushed a commit
that referenced
this issue
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
rank()
function convertsnp.nan
tonp.inf
or-np.inf
, and therefore can't properly rank existingnp.inf
. See here: #6886 (comment).Test for this issue here: https://github.com/pydata/pandas/blob/master/pandas/tests/test_series.py#L4071
The text was updated successfully, but these errors were encountered: