-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Enhancement: Add dropna to Float64Index #6194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
it could keep in mind that the indexing code for Nan's is really hairy - so maybe a good idea! |
yeah, this was the result of prematurely making something the index while I should have dropped the NaNs before assigning it as an index. So maybe it's better to teach the user to prevent NaNs in the index? Possibly would avoid a lot of other issues. |
the problem with nan in an index is that selection basically goes out the window and indexes are almost useless because since nan != nan and so ordering is shot can you post a usecase? what we maybe could do is have an index that has a fill value so that ordering / selection is maintained, but treat it as missing - just a thought |
i'm not sure i CAN defend a use case, now that I remember how bad NaNs are in the index? |
no warning as setting an index possibly containing nan's is allowed. Its really the indexing of it that is the problem, which does raise an exception in some cases. Their needs to be some more work in this area in any event. If you do find a case where nans are useful (or a nuiscance) in a Float64Index, pls post. |
Any reason why it could not have a dropna()?
The text was updated successfully, but these errors were encountered: