Skip to content

DOC: Little contrast in documentation accordion cards #60921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Cladis opened this issue Feb 12, 2025 · 1 comment
Closed
1 task done

DOC: Little contrast in documentation accordion cards #60921

Cladis opened this issue Feb 12, 2025 · 1 comment
Labels

Comments

@Cladis
Copy link

Cladis commented Feb 12, 2025

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://pandas.pydata.org/docs/getting_started/index.html

Documentation problem

Originally I reported upstream to the pydata-sphinx-theme issue tracker: pydata/pydata-sphinx-theme#2110

On the pandas Getting started page, https://pandas.pydata.org/docs/getting_started/index.html, I saw following when using dark theme in Firefox 134.0 (64-bit) on Ubuntu:

Image

I could not really read the text of the spoiler names under Intro to pandas as they are virtually black on black, so I am forced to switch to light mode instead. (Looking at the code what I am looking at seems to be called tutorial accordion cards, but I might be wrong).

The theme developers in the upstream issue noted that the component used seems to be a custom one built by the Pandas team, so reporting this here.

BUT as I was in the process of reporting it here the checkbox at the top of the form had asked me to check whether the issue still persists in the dev version of the documentation. Funny thing is that it doesn't. But it became worse. Now instead of the spoiler title being unreadable the spoiler body isn't:

Image

Suggested fix for documentation

The component in question or its application should be fixed so that text is readable in both dark and light themes.

@Cladis Cladis added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 12, 2025
@rhshadrach
Copy link
Member

Thanks for the report. Closing as a duplicate of #60024

@rhshadrach rhshadrach removed the Needs Triage Issue that has not been reviewed by a pandas team member label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants