Skip to content

DOC: Intro to pandas table not readily visible in dark mode #60024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhshadrach opened this issue Oct 12, 2024 · 6 comments
Closed

DOC: Intro to pandas table not readily visible in dark mode #60024

rhshadrach opened this issue Oct 12, 2024 · 6 comments
Assignees
@Ishwar0309 @easternsun7
Labels
Docs
Milestone
2.3

Comments

@rhshadrach
Copy link
Member

https://pandas.pydata.org/docs/getting_started/index.html#intro-to-pandas

This issue exists on 2.2 and the 2.3.x branch but not main. I think this is not worth fixing for 2.2 (would require a release I think), but could be fixed before we release 2.3.
@rhshadrach rhshadrach added this to the 2.3 milestone Oct 12, 2024
@rhshadrach rhshadrach changed the title DOC: Intro to pandas not visible in dark mode DOC: Intro to pandas table not readily visible in dark mode Oct 12, 2024
@Ishwar0309
Copy link

take

@easternsun7
Copy link
Contributor

take

@easternsun7
Copy link
Contributor

https://pandas.pydata.org/docs/getting_started/index.html#intro-to-pandas

This issue exists on 2.2 and the 2.3.x branch but not main. I think this is not worth fixing for 2.2 (would require a release I think), but could be fixed before we release 2.3.

Perhaps we could set this part of the font color to blue, which is highly visible in either bright or dark mode, so that there is no need to implement a font color that changes with the theme.

easternsun7 added a commit to easternsun7/pandas that referenced this issue Oct 13, 2024
@easternsun7
Update getting_started.css
6dff32e 
The problem is "DOC: Intro to pandas table not readily visible in dark mode pandas-dev#60024"
Perhaps we could set this part of the font color to blue, which is highly visible in either bright or dark mode, so that there is no need to implement a font color that changes with the theme.
@easternsun7 easternsun7 mentioned this issue Oct 13, 2024
Closed
@asishm asishm mentioned this issue Oct 14, 2024
Closed
1 task
@KevsterAmp
Copy link
Contributor

I believe we can close this issue, since this has been resolved based on #60041

cc: @rhshadrach

@rhshadrach
Copy link
Member Author

@KevsterAmp - looks like that issue was closed because it is a duplicate of this.

@rhshadrach rhshadrach mentioned this issue Feb 12, 2025
Closed
1 task
@asishm asishm mentioned this issue Apr 29, 2025
Closed
@danielpintosalazar danielpintosalazar mentioned this issue Apr 30, 2025
Merged
1 task
mroeschke pushed a commit that referenced this issue Apr 30, 2025
@danielpintosalazar
DOC: Fix dark mode text visibility in Getting Started accordion (#60024…
e55d907 
…) (#61379)

Fix: text color for accordion content in getting started
@mroeschke
Copy link
Member

Closed by #61379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ishwar0309 Ishwar0309

@easternsun7 easternsun7

Labels
Docs
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
5 participants
@mroeschke @Ishwar0309 @rhshadrach @KevsterAmp @easternsun7