BUG: get_option_data

[joejohnson111]

looked at this this morning some. In the _get_option_data function, when building the url for yahoo, if I try to get current month but forward year, I get the +Options url which returns nearest expiry. The way I quickly fixed it, but i'm not sure its the best way

        if year != CUR_YEAR:
                url += '&m={year}-{m1}'.format(year=year, m1=m1)


        else:
                if m1 != CUR_MONTH and m2 != CUR_MONTH:
                    url += '&m={year}-{m1}'.format(year=year, m1=m1)
                else:
                    url += '+Options'

else:  # Default to current month
      url += '+Options'

I apologize in advance for any bad formatting or etiquette as I'm only just starting to use github.

Thanks

[jreback]

you want to do some tests and a PR for this?

[joejohnson111]

Sure. Just let me know what you need.

jreback [email protected] wrote:

you want to do some tests and a PR for this?

---

Reply to this email directly or view it on GitHub:
#6012 (comment)

[jreback]

see here: http://pandas.pydata.org/developers.html

you fixed an issue...so need to write some tests which duplicate the problem (and have them fail)
then apply your solution

wrap it up in a Pull-Request and submit!

[jreback]

@joejohnson111 PR for this?

[jreback]

does #5602 solve this? (its in 0.14.1)

[jreback]

pretty sure this is fixed in 0.14.1. pls open a new issue if you find the functionaility still lacking.