Skip to content

BUG: get_option_data #6012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joejohnson111 opened this issue Jan 20, 2014 · 6 comments
Closed

BUG: get_option_data #6012

joejohnson111 opened this issue Jan 20, 2014 · 6 comments
Labels
Milestone

Comments

@joejohnson111
Copy link

looked at this this morning some. In the _get_option_data function, when building the url for yahoo, if I try to get current month but forward year, I get the +Options url which returns nearest expiry. The way I quickly fixed it, but i'm not sure its the best way

        if year != CUR_YEAR:
                url += '&m={year}-{m1}'.format(year=year, m1=m1)


        else:
                if m1 != CUR_MONTH and m2 != CUR_MONTH:
                    url += '&m={year}-{m1}'.format(year=year, m1=m1)
                else:
                    url += '+Options'

else:  # Default to current month
      url += '+Options'

I apologize in advance for any bad formatting or etiquette as I'm only just starting to use github.

Thanks

@jreback
Copy link
Contributor

jreback commented Jan 25, 2014

you want to do some tests and a PR for this?

@joejohnson111
Copy link
Author

Sure. Just let me know what you need.

jreback [email protected] wrote:

you want to do some tests and a PR for this?


Reply to this email directly or view it on GitHub:
#6012 (comment)

@jreback
Copy link
Contributor

jreback commented Jan 25, 2014

see here: http://pandas.pydata.org/developers.html

you fixed an issue...so need to write some tests which duplicate the problem (and have them fail)
then apply your solution

wrap it up in a Pull-Request and submit!

@jreback
Copy link
Contributor

jreback commented Feb 14, 2014

@joejohnson111 PR for this?

@jreback jreback modified the milestones: 0.15.0, 0.14.0 Feb 14, 2014
@jreback
Copy link
Contributor

jreback commented Jul 6, 2014

does #5602 solve this? (its in 0.14.1)

@jreback
Copy link
Contributor

jreback commented Oct 1, 2014

pretty sure this is fixed in 0.14.1. pls open a new issue if you find the functionaility still lacking.

@jreback jreback closed this as completed Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants