Skip to content

BUG: provide better error message for pd.Timedelta - pd.Series[Timestamp] #59571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 3 tasks
sfc-gh-mvashishtha opened this issue Aug 21, 2024 · 10 comments
Open
2 of 3 tasks
Assignees
Labels
Datetime Datetime data dtype Error Reporting Incorrect or improved errors from pandas

Comments

@sfc-gh-mvashishtha
Copy link

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

import pandas as pd

pd.Timedelta(10) - pd.Series([pd.Timestamp(1)])

Issue Description

You can do the same subtraction with integers (1 - pd.Series(10)), and you can also do pd.Timedelta + pd.Series[Timestamp] (pd.Timedelta(10) + pd.Series([pd.Timestamp(1)])), so pandas should be consistent and allow pd.Timedelta - pd.Series[Timestamp]

#25497 is an older, closed issue about the error message here, but this scenario shouldn't cause an error at all.

Expected Behavior

Should subtract the scalar from each element of the series/dataframe/index

Installed Versions

INSTALLED VERSIONS
------------------
commit                : d9cdd2ee5a58015ef6f4d15c7226110c9aab8140
python                : 3.9.18.final.0
python-bits           : 64
OS                    : Darwin
OS-release            : 23.6.0
Version               : Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:04 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6020
machine               : arm64
processor             : arm
byteorder             : little
LC_ALL                : None
LANG                  : en_US.UTF-8
LOCALE                : en_US.UTF-8

pandas                : 2.2.2
numpy                 : 1.26.3
pytz                  : 2023.3.post1
dateutil              : 2.8.2
setuptools            : 68.2.2
pip                   : 23.3.1
Cython                : None
pytest                : None
hypothesis            : None
sphinx                : None
blosc                 : None
feather               : None
xlsxwriter            : None
lxml.etree            : None
html5lib              : None
pymysql               : None
psycopg2              : None
jinja2                : None
IPython               : 8.18.1
pandas_datareader     : None
adbc-driver-postgresql: None
adbc-driver-sqlite    : None
bs4                   : None
bottleneck            : None
dataframe-api-compat  : None
fastparquet           : None
fsspec                : None
gcsfs                 : None
matplotlib            : None
numba                 : None
numexpr               : None
odfpy                 : None
openpyxl              : None
pandas_gbq            : None
pyarrow               : None
pyreadstat            : None
python-calamine       : None
pyxlsb                : None
s3fs                  : None
scipy                 : None
sqlalchemy            : None
tables                : None
tabulate              : None
xarray                : None
xlrd                  : None
zstandard             : None
tzdata                : 2023.4
qtpy                  : None
pyqt5                 : None

@sfc-gh-mvashishtha sfc-gh-mvashishtha added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 21, 2024
@mroeschke
Copy link
Member

Addition with these types is a communicate operation, but subtraction is not and is undefined even with analogous scalars from the standard library

In [1]: import datetime

In [2]: datetime.timedelta(1) - datetime.datetime.now()
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[2], line 1
----> 1 datetime.timedelta(1) - datetime.datetime.now()

TypeError: unsupported operand type(s) for -: 'datetime.timedelta' and 'datetime.datetime'

In [3]: import pandas as pd

In [4]: pd.Timedelta(1) - pd.Timestamp.now()
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[4], line 1
----> 1 pd.Timedelta(1) - pd.Timestamp.now()

TypeError: unsupported operand type(s) for -: 'Timedelta' and 'Timestamp'

@mroeschke mroeschke added Closing Candidate May be closeable, needs more eyeballs and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 21, 2024
@sfc-gh-mvashishtha
Copy link
Author

@mroeschke yes, now that I think about it, this operation doesn't make sense in pandas either. However, the error message bad operand type for unary - is opaque. Can we change the error message so it looks more like the scalar Timedelta - Timestamp ones, i.e. so it includes unsupported operand type(s) for -?

@jorisvandenbossche jorisvandenbossche added Usage Question Error Reporting Incorrect or improved errors from pandas and removed Bug Usage Question Closing Candidate May be closeable, needs more eyeballs labels Aug 22, 2024
@jorisvandenbossche jorisvandenbossche changed the title BUG: pd.Timedelta - pd.Series[Timestamp] raises TypeError: bad operand type for unary -: 'DatetimeArray' BUG: provide better error message for pd.Timedelta - pd.Series[Timestamp] Aug 22, 2024
@jorisvandenbossche
Copy link
Member

Agreed that it would be nice to have a clearer error message (renamed/relabeled the issue as such)

@KevsterAmp
Copy link
Contributor

Take

@AshmitGupta
Copy link

@KevsterAmp Still working on this issue or can I assign it to myself?

@KevsterAmp
Copy link
Contributor

You can assign it to yourself. @AshmitGupta

@KevsterAmp
Copy link
Contributor

Will be going to continue to work on this

@KevsterAmp KevsterAmp removed their assignment Sep 25, 2024
@KevsterAmp
Copy link
Contributor

take

@KevsterAmp
Copy link
Contributor

take

@KevsterAmp KevsterAmp removed their assignment Oct 3, 2024
@KevsterAmp
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Error Reporting Incorrect or improved errors from pandas
Projects
None yet
6 participants