-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: "Accelerated operations" talks about speedup in obsolete versions of Pandas #59130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the suggestion! While this change would in fact portray the speed difference, the problem with it is that the speeds may become inaccurate overtime, so I think keeping the version number is necessary. How about updating it with something like: |
I would recommend just removing that timing table section and just linking to https://pandas.pydata.org/pandas-docs/stable/user_guide/enhancingperf.html#eval-performance-comparison instead |
Is this still up .. as first time contributor, I would like to work on this if possible ? |
@BadakalaYashwanth or @mroeschke can I take over this issue ? seems like BadakalaYashwanth has not seen this update. |
Hi @TheRockStarDBA, Apologies for missing your update. You can certainly take over the issue. Please let me know if there’s anything specific you need from me or if there are any additional details I should be aware of. Thanks for stepping in! Best, |
take |
@TheRockStarDBA are you still working on this? |
@KevsterAmp yes .. submitting a PR soon. |
@TheRockStarDBA Hey, I tried to play a little bit with devin and open source and he chose this issue out of the many "easy" issues that exists in this repo. He solved the problem by removing it but if you have better solution it will probably be better. |
Pandas version checks
main
hereLocation of the documentation
https://pandas.pydata.org/pandas-docs/stable/user_guide/basics.html#accelerated-operations
Permalink to specific line:
pandas/doc/source/user_guide/basics.rst
Line 161 in a89f208
Documentation problem
0.11.0 is more than 10 years old and, of course, before the first stable release.
Suggested fix for documentation
If the important thing is the speedup you get from enabling a feature, then just talk about the speedup instead of when the feature first became available.
Something like this:
:header: "Operation", "With speedup (ms)", "Without speedup (ms)", "Ratio"
The text was updated successfully, but these errors were encountered: