Skip to content

DOC: to_sql docs should mention ADBC #59095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
WillAyd opened this issue Jun 25, 2024 · 2 comments · Fixed by #59198
Closed
1 task done

DOC: to_sql docs should mention ADBC #59095

WillAyd opened this issue Jun 25, 2024 · 2 comments · Fixed by #59198
Assignees
@wooseogchoi
Labels
Docs good first issue

Comments

@WillAyd
Copy link
Member

WillAyd commented Jun 25, 2024

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.to_sql.html

Documentation problem

The to_sql documentation does not mention anything about supporting ADBC connections. By contrast the read_sql function does:

https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.read_sql.html

Suggested fix for documentation

Add mention / example of ADBC usage with the to_sql method
@WillAyd WillAyd added Docs Needs Triage Issue that has not been reviewed by a pandas team member and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 25, 2024
@WillAyd WillAyd mentioned this issue Jun 25, 2024
Merged
@gosuchoi
Copy link

taken

@wooseogchoi
Copy link
Contributor

take

@wooseogchoi wooseogchoi mentioned this issue Jul 7, 2024
Merged
2 tasks
mroeschke pushed a commit that referenced this issue Jul 8, 2024
@wooseogchoi
DOC: added adbc connection in con parameter of to_sql and example of …
61c5fbf 
…its usage (#59198)

* doc: to_sql docs should mention ADBC #59095

* remove two blank lines at the end of docstring.

* added one more space in in-line comments of example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wooseogchoi wooseogchoi

Labels
Docs good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOC: added adbc connection in con parameter of to_sql and example of its usage
4 participants
@WillAyd @gosuchoi @wooseogchoi @Aloqeely