Skip to content

ENH: Allow users to disable PerformanceWarning #56920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhshadrach opened this issue Jan 17, 2024 · 1 comment · Fixed by #56921
Closed

ENH: Allow users to disable PerformanceWarning #56920

rhshadrach opened this issue Jan 17, 2024 · 1 comment · Fixed by #56921
Labels
Enhancement Needs Discussion Requires discussion from core team before further action Warnings Warnings that appear or should be added to pandas

Comments

@rhshadrach
Copy link
Member

rhshadrach commented Jan 17, 2024

Part of the way toward #55385. Even if we decide not to implement #55385 (i.e. performance warnings are disabled by default), I think this is a good option for users to have.

I propose adding an option, mode.performance_warnings defaulting to True, that users could set to False to disable all PerformanceWarnings from being raised. The difference between this and #55385 is just changing the default value.

I opened #56921 to show the implementation.

Would like to get feedback on the general idea and happy to bikeshed the option name. Since this is impacts many places, cc @pandas-dev/pandas-core.

@rhshadrach rhshadrach added Enhancement Needs Discussion Requires discussion from core team before further action Warnings Warnings that appear or should be added to pandas labels Jan 17, 2024
@jorisvandenbossche
Copy link
Member

Such an option sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Needs Discussion Requires discussion from core team before further action Warnings Warnings that appear or should be added to pandas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants