Skip to content

DOC: Remove references to AxesSubPlot #56876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Dr-Irv opened this issue Jan 14, 2024 · 5 comments · Fixed by #56943
Closed
1 task done

DOC: Remove references to AxesSubPlot #56876

Dr-Irv opened this issue Jan 14, 2024 · 5 comments · Fixed by #56943
Assignees
Labels
Docs good first issue Groupby Typing type annotations, mypy/pyright type checking Visualization plotting

Comments

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Jan 14, 2024

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://pandas.pydata.org/docs/dev/reference/api/pandas.core.groupby.SeriesGroupBy.hist.html (and other places)

Documentation problem

AxesSubplot was removed from matplotlib, so we need to remove it from our docs.

See matplotlib/matplotlib#18222

Suggested fix for documentation

Change the type from AxesSubplot in the docs to Axes

@Dr-Irv Dr-Irv added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 14, 2024
@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jan 14, 2024

Also, the xlabelsize and ylabelsize arguments can be float or str, so types and docs have to change. These are converted to matplotlib font sizes which can be float or str

@rhshadrach rhshadrach added Groupby Visualization plotting good first issue Typing type annotations, mypy/pyright type checking and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 16, 2024
@manlattan
Copy link
Contributor

@Dr-Irv Can I get this issue? I would like to work on this issue!

@luke396
Copy link
Contributor

luke396 commented Jan 16, 2024

Friendly reminder, @manlattan! To address the issue, simply comment 'take,' and the issue will be automatically assigned to you. Feel free to begin resolving it at your convenience.

@manlattan
Copy link
Contributor

take

@manlattan
Copy link
Contributor

@luke396 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs good first issue Groupby Typing type annotations, mypy/pyright type checking Visualization plotting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants