We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index.view has a cls argument (instead of dtype, which I would expect) and starts with:
cls
# we need to see if we are subclassing an # index type here if cls is not None and not hasattr(cls, "_typ"):
The "_typ" check must have been intended to catch types defined in pd.core.dtypes.generic, but it isn't clear to me why we do that.
Let's just have view take a dtype keyword like Series.view.
update: also it sometimes returns an Index and other times an ArrayLike. let's choose just one.
The text was updated successfully, but these errors were encountered:
Or deprecate it, like we want to do for Series (#20251), and only keep it on the array level?
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Index.view has a
cls
argument (instead of dtype, which I would expect) and starts with:The "_typ" check must have been intended to catch types defined in pd.core.dtypes.generic, but it isn't clear to me why we do that.
Let's just have view take a dtype keyword like Series.view.
update: also it sometimes returns an Index and other times an ArrayLike. let's choose just one.
The text was updated successfully, but these errors were encountered: