Skip to content

BUG: Missing assert in test_interval_new.py in test_loc_with_overlap #55557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
Sjord opened this issue Oct 17, 2023 · 0 comments · Fixed by #55560
Closed
3 tasks done

BUG: Missing assert in test_interval_new.py in test_loc_with_overlap #55557

Sjord opened this issue Oct 17, 2023 · 0 comments · Fixed by #55560
Labels
Bug Needs Triage Issue that has not been reviewed by a pandas team member

Comments

@Sjord
Copy link

Sjord commented Oct 17, 2023

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

In pandas/pandas/tests/indexing/interval/test_interval_new.py at 746e5eee860b6e143c33c9b985e095dac2e42677 · pandas-dev/pandas

        # interval
        expected = 0
        result = indexer_sl(ser)[Interval(1, 5)]
        result == expected

The final line, result == expected should probably be assert result == expected or tm.assert_series_equal(expected, result).

Issue Description

Values are compared in the unit tests, but the result of the comparison is discarded instead of asserted.

Expected Behavior

An assertion

Installed Versions

v2.2.0.dev0-383-g746e5eee86

@Sjord Sjord added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 17, 2023
@jayendra-patil33 jayendra-patil33 mentioned this issue Oct 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Needs Triage Issue that has not been reviewed by a pandas team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant