Skip to content

REF: groupby internal names #55551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rhshadrach opened this issue Oct 16, 2023 · 2 comments
Open

REF: groupby internal names #55551

rhshadrach opened this issue Oct 16, 2023 · 2 comments
Labels
Groupby Needs Discussion Requires discussion from core team before further action Refactor Internal refactoring of code

Comments

@rhshadrach
Copy link
Member

I'd like to start gathering / discussing refactoring some of the naming within pandas.core.groupby. These are some initial ones that come to mind, I plan to expand this issue in the near future.

Issues:

  • (DEPR: pandas.core for groupby #55429 (comment)) generic.py has subclasses, whereas core.generic.py has the base class NDFrame.
  • result_index is only the result index for aggregations.
  • Is the 'b' capitalized in class names? DataFrameGroupBy vs ExpandingGroupby

Resolutions:
@rhshadrach rhshadrach added Refactor Internal refactoring of code Groupby Needs Discussion Requires discussion from core team before further action labels Oct 16, 2023
@rhshadrach
Copy link
Member Author

For generic.py, I'd like to split this into one for SeriesGroupBy and one for DataFrameGroupBy. This would make it easier to determine what method you're looking at (the Series version vs the DataFrame version). I propose either calling them series.py and frame.py or series_groupby.py and frame_groupby.py.

For result_index, I'd like to rename this agg_index.

cc @jbrockmendel

@jbrockmendel
Copy link
Member

For result_index, I'd like to rename this agg_index.

fine by me

gusthavoMFS added a commit to gusthavoMFS/pandas that referenced this issue Oct 26, 2023
@gusthavoMFS
REF: groupby internal names (pandas-dev#55551)
a7c8f77
gusthavoMFS added a commit to gusthavoMFS/pandas that referenced this issue Oct 27, 2023
@gusthavoMFS
REF: groupby internal names (pandas-dev#55551)
27f0e5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Groupby Needs Discussion Requires discussion from core team before further action Refactor Internal refactoring of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockmendel @rhshadrach