Skip to content

CI: Test daily with pandas-stubs tests #54095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dr-Irv opened this issue Jul 12, 2023 · 0 comments
Open

CI: Test daily with pandas-stubs tests #54095

Dr-Irv opened this issue Jul 12, 2023 · 0 comments
Labels
CI Continuous Integration Typing type annotations, mypy/pyright type checking

Comments

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Jul 12, 2023

From discussion at dev meeting on 7/12/2023:

Idea is that pandas-stubs project has tests here: https://github.com/pandas-dev/pandas-stubs/tree/main/tests

When changes are merged into main on pandas, the tests in pandas-stubs may reveal bugs or new warnings that current tests in pandas are not picking up. Or the new warnings need to be accounted for in the pandas-stubs tests.

Suggestion is to have some part of the pandas CI do a daily test on the pandas-stubs tests using pytest -Werror and if that test picks up a failure, to auto-create an issue in pandas and/or the pandas-stubs repo so that issue can be investigated and dealt with, either in the pandas code in case of a new exception, or in the pandas-stubs tests if a new warning is being issued.

See pandas-dev/pandas-stubs#742 of an example of a pandas-stubs PR that fixed the tests for pandas-stubs as a result of doing a test on nightly builds of pandas, and #54055, #54056, #54056 and #54059 as a set of pandas issues created as a result of doing the triage that created the pandas-stubs PR.

Tagging a few people who contributed to the discussion: @MarcoGorelli @lthomas1 @mroeschke

@mroeschke mroeschke added CI Continuous Integration Typing type annotations, mypy/pyright type checking labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

No branches or pull requests

2 participants