Skip to content

CLN: use lib.no_default instead of lib.NoDefault in reshape.pivot #53826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Jun 23, 2023 · 1 comment · Fixed by #53877
Closed

CLN: use lib.no_default instead of lib.NoDefault in reshape.pivot #53826

jbrockmendel opened this issue Jun 23, 2023 · 1 comment · Fixed by #53877
Labels
Clean Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Jun 23, 2023 •
edited
Loading

In core.reshape.pivot we have a couple places where a default kwarg is lib.NoDefault where the idiomatic usage would be lib.no_default. I assumed this was just a typo, but when I tried changing it, some tests broke. Need to track down what's going on there.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 23, 2023
@lithomas1 lithomas1 added Clean and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 23, 2023
@rhshadrach rhshadrach added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Jun 23, 2023
@Charlie-XIAO
Copy link
Contributor

Charlie-XIAO commented Jun 24, 2023 •
edited
Loading

@jbrockmendel Seems that in pandas/core/frame.py and pandas/tests/reshape/test_pivot_multilevel.py there are also such typos, maybe this is the reason b/c they explicitly pass lib.NoDefault when calling pivot. I tried changing those as well and the test cases pass. Are you already working on a PR? Otherwise I can help.

Edit: since there is no reply and I did not find an existing PR for this, I will just go ahead.

@Charlie-XIAO Charlie-XIAO mentioned this issue Jun 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLN: use lib.no_default instead of lib.NoDefault in .pivot Charlie-XIAO/pandas
4 participants
@jbrockmendel @rhshadrach @lithomas1 @Charlie-XIAO