Skip to content

Unused Imports in tseries.tools #5306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cancan101 opened this issue Oct 24, 2013 · 2 comments
Closed

Unused Imports in tseries.tools #5306

cancan101 opened this issue Oct 24, 2013 · 2 comments
Labels
Frequency DateOffsets
Milestone
0.15.0

Comments

@cancan101
Copy link
Contributor

Imports https://github.com/pydata/pandas/blob/master/pandas/tseries/tools.py#L213 and https://github.com/pydata/pandas/blob/master/pandas/tseries/tools.py#L214 are not used:

from pandas.tseries.offsets import DateOffset
from pandas.tseries.frequencies import (_get_rule_month, _month_numbers,
                                            _get_freq_str)

Is there any reason to leave these?
Is there an open ticket for removing unused imports?
@cancan101 cancan101 mentioned this issue Nov 2, 2013
Closed
@ghost
Copy link

ghost commented Jan 24, 2014

Put up a "no-brainer" PR that's green on travis and I'll merge.

@ghost ghost closed this as completed Jan 24, 2014
@jreback jreback reopened this Apr 3, 2014
@jreback jreback modified the milestones: 0.14.1, 0.14.0 Apr 27, 2014
@jreback jreback modified the milestones: 0.15.0, 0.14.1 Jun 10, 2014
@jreback jreback modified the milestones: 0.15.0, 0.15.1 Jul 6, 2014
@jreback
Copy link
Contributor

jreback commented Jul 28, 2014

#7854 obviates this

@jreback jreback closed this as completed Jul 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Frequency DateOffsets
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

ENH: Cleanup backend for Offsets and Period cancan101/pandas
2 participants
@cancan101 @jreback