-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH/DOC: call for Timestamp #5168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The second argument is not the timezone, it's the offset. This could maybe use some better documentation if that wasn't already clear somewhere in the docs. |
Thought ideally, it should fail in this case and not just continue on |
I agree. I don't see an example of creating a standalone |
here would welcome a PR & docstring update! |
@adamgreenhall want to do some docs / example for Timestamp? maybe update the doc string as well
|
However, there is a problem with documenting |
Is this handled by #17943, or is there a distinct issue? |
yep, want to add a validation test to close this? |
When you create a timestamp with a timezone and don't use a keyword argument, it fails silently:
The text was updated successfully, but these errors were encountered: