Skip to content

REF/API: make pd.Grouper immutable #51134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Feb 2, 2023 · 2 comments · Fixed by #51206
Closed

REF/API: make pd.Grouper immutable #51134

jbrockmendel opened this issue Feb 2, 2023 · 2 comments · Fixed by #51206
Labels
Groupby Refactor Internal refactoring of code

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Feb 2, 2023 •
edited
Loading

Grouper._set_grouper (called by Grouper._get_grouper) sets some of its own attributes. It would be much easier to reason about this code if this were not the case. An afternoon spent trying to disentangle this has not gotten me very far. This may need a more invasive fix.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 2, 2023
@jbrockmendel jbrockmendel mentioned this issue Feb 3, 2023
Merged
@rhshadrach rhshadrach added Refactor Internal refactoring of code Groupby and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 3, 2023
This was referenced Feb 3, 2023
Merged
Merged
@topper-123
Copy link
Contributor

+1.

@jbrockmendel
Copy link
Member Author

xref #26564, #41930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Groupby Refactor Internal refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEPR: Grouper.ax, Grouper.obj, Grouper.indexer jbrockmendel/pandas
3 participants
@jbrockmendel @topper-123 @rhshadrach