TST: Cleanup tests from numeric_only / nuisance deprecation

[rhshadrach]

In enforcing the numeric_only / silent dropping of nuisance columns deprecations for 2.0, many of our tests now have the following pattern:

df = pd.DataFrame({'a': [1, 2, 3], 'b': ['x', 'y', 'z']})
with pytest.raises(TypeError, match=...):
   df.mean()
result = df.mean(numeric_only=True)
expected = ...
tm.assert_series_equal(result, expected)

I think it would be better to consolidate these into a small group of tests, something like test_op_raises_on_invalid_type, and remove the invalid types from the remainder of the tests.

cc @mroeschke

[albuzenet]

take

[albuzenet]

Hello rhshadrach, this will be my first contribution to pandas. Do you have any example of test/file I can start with ? Maybe the work can be split if there is a lot to be done ?

[rhshadrach]

@AlexBuzenet - you can find examples by searching the tests for numeric_only=True; while not all of these will be examples, a good amount will. It's only an example when it fits the pattern described above. Here is one such example:

pandas/pandas/tests/extension/base/groupby.py

Lines 145 to 147 in 5ee4dac

	with pytest.raises(TypeError, match="does not support"):
	df.groupby("A").sum().columns
	result = df.groupby("A").sum(numeric_only=True).columns

I'd recommend naming the files test_invalid_op.py (the name may be workshopped) that will go in various subdirectories - e.g. frame and groupby - within the tests directory. In working on this issue, we want to make sure we don't lose test coverage. So for any removed test we need to point at a similar test in the new location.

I'll plan to do one example PR in the next day or two in groupby.

As for splitting this up, I think that's a good idea but it would require a list of tests. I don't have that at the moment, and it would take some time to create.

[albuzenet]

@rhshadrach I just opened a PR extending your work in groupby. Let me know if it is what is expected. Should we continue with frame after groupby ?

[jbrockmendel]

a lot of these exist in tests.groupby.test_raises

[luke396]

This issue has been silent for a while, I can continue to finish it.

[rhshadrach]

@luke396 - that's be great. I've lost track of where things stand here.